Github user jeking3 commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/1476#discussion_r163623295
  
    --- Diff: lib/cpp/src/thrift/transport/TSSLSocket.h ---
    @@ -78,6 +78,7 @@ class TSSLSocket : public TSocket {
       bool peek();
       void open();
       void close();
    +  bool hasPendingDataToRead();
    --- End diff --
    
    Note that the cross test suite currently does not test asynchronous.  It is 
more of a protocol test; it would be interesting to add one more matrix choice 
of threaded vs. nonblocking for the languages that support it, and test both 
against both.


---

Reply via email to