[ 
https://issues.apache.org/jira/browse/THRIFT-4474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16338457#comment-16338457
 ] 

ASF GitHub Bot commented on THRIFT-4474:
----------------------------------------

GitHub user RobberPhex opened a pull request:

    https://github.com/apache/thrift/pull/1479

    THRIFT-4474: generate PHP code use PSR-4 style default

    ref: https://issues.apache.org/jira/browse/THRIFT-4474

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/RobberPhex/thrift default-psr4

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/1479.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1479
    
----
commit a083deebd3977f68bf5fdfe1d2e88ea240f8183a
Author: Robert Lu <robberphex@...>
Date:   2018-01-17T11:40:39Z

    generate PHP code use PSR-4 style default

----


> PHP generator use PSR-4 default
> -------------------------------
>
>                 Key: THRIFT-4474
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4474
>             Project: Thrift
>          Issue Type: Improvement
>          Components: PHP - Compiler
>            Reporter: Robert Lu
>            Assignee: Robert Lu
>            Priority: Major
>
> Before, PHP generator generate php files like {{Types.php}}, {{Service.php}}.
> Those can only be load via 
> [{{classmap}}|https://getcomposer.org/doc/04-schema.md#classmap] method. The 
> latest PSR about autoload is [PSR-4|http://www.php-fig.org/psr/psr-4/].
> thrift compiler can generate PSR-4 code default, if want old-style code(which 
> can only load via classmap), add {{classmap}} option.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to