[
https://issues.apache.org/jira/browse/THRIFT-4477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16344421#comment-16344421
]
ASF GitHub Bot commented on THRIFT-4477:
----------------------------------------
GitHub user RobberPhex opened a pull request:
https://github.com/apache/thrift/pull/1484
TBufferedTransport must have underlying transport
ref: https://issues.apache.org/jira/browse/THRIFT-4477
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/RobberPhex/thrift fix-TBufferedTransport
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1484.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1484
----
commit 3c72a16259b64c2fd38f160b67575b3b932c5e62
Author: Robert Lu <robberphex@...>
Date: 2018-01-29T14:49:12Z
TBufferedTransport must have underlying transport
* add some type hinting
----
> TBufferedTransport must have underlying transport
> -------------------------------------------------
>
> Key: THRIFT-4477
> URL: https://issues.apache.org/jira/browse/THRIFT-4477
> Project: Thrift
> Issue Type: Bug
> Components: PHP - Library
> Affects Versions: 0.11.0
> Reporter: Robert Lu
> Assignee: Robert Lu
> Priority: Major
>
> for TBufferedTransport,
> the underlying transport cannot be null. many methods used underlying
> transport directly, if it's null, will cause error. And a null as underlying
> transport for TBufferedTransport makes no sense.
> So, TBufferedTransport must have underlying transport
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
