[
https://issues.apache.org/jira/browse/THRIFT-4485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16349441#comment-16349441
]
ASF GitHub Bot commented on THRIFT-4485:
----------------------------------------
GitHub user Jens-G opened a pull request:
https://github.com/apache/thrift/pull/1489
THRIFT-4485 Possible invalid ptr AV with overlapped read/write on pipes
Client: Delphi
Patch: Jens Geyer
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Jens-G/thrift THRIFT-4485
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1489.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1489
----
commit 10f90c16a0d9e6275b33086fc90bc2e6ae2d81cd
Author: Jens Geyer <jensg@...>
Date: 2018-02-01T22:38:10Z
THRIFT-4485 Possible invalid ptr AV with overlapped read/write on pipes
Client: Delphi
Patch: Jens Geyer
----
> Possible invalid ptr AV with overlapped read/write on pipes
> -----------------------------------------------------------
>
> Key: THRIFT-4485
> URL: https://issues.apache.org/jira/browse/THRIFT-4485
> Project: Thrift
> Issue Type: Bug
> Components: Delphi - Library
> Reporter: Jens Geyer
> Assignee: Jens Geyer
> Priority: Critical
>
> If a read or write operation on pipes reaches the set timeout, the read/write
> operation is not properly cancelled. However, the overlapped struct gets
> freed when leaving the method, which essentially leaves the pending read or
> write operation with an undefined pointer.
> Easily reproducible with buffered transport over pipes, a combination that
> does not work at all anyways. The workaround for both problems is to not use
> buffered transport with pipes (use framed instead), and some sane tinemouts
> (not too short).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
