John Boiles created THRIFT-4486: ----------------------------------- Summary: Golang: -remote.go client cleanup Key: THRIFT-4486 URL: https://issues.apache.org/jira/browse/THRIFT-4486 Project: Thrift Issue Type: Task Components: Go - Compiler Affects Versions: 0.11.0 Reporter: John Boiles
PR Here: [https://github.com/apache/thrift/pull/1488] There are a few issues with the generated {{-remote.go}} clients, fixed in the above PR. * (bug) CLI input is decoded with TSimpleJsonProtocol which does not support json->thrift serialization ([see also|https://github.com/apache/thrift/blob/19baeefd8c38d62085891d7956349601f79448b3/lib/go/thrift/simple_json_protocol.go#L335]) (so there is no way to input data) * {{(bug) *-remote.go}} files for generated Thrift packages with no services fail to compile since {{client}} is unused. (also these {{-remote.go}} files are not useful if there are no services) * {{(bug) https}} urls fail (since the {{useHttp}} check only checks for {{"http"}}) * (feature) Http headers aren't supported, so servers with header auth cannot be used -- This message was sent by Atlassian JIRA (v7.6.3#76005)