[ 
https://issues.apache.org/jira/browse/THRIFT-4448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16350795#comment-16350795
 ] 

ASF GitHub Bot commented on THRIFT-4448:
----------------------------------------

Github user johnboiles commented on the issue:

    https://github.com/apache/thrift/pull/1459
  
    It's not clear to me what went wrong in the Travis build. Trusty, for 
example, seems to have stack overflow'd while installing ocaml. Is there a way 
to retrigger a build without pushing another commit?
    
    ```
    [default] synchronized from https://opam.ocaml.org
    Stack overflow
    [ERROR] Initialisation failed
    Fatal error:
    Stack overflow
    The command '/bin/sh -c apt-get install -y --no-install-recommends `# OCaml 
dependencies`       ocaml       opam &&     opam init --yes &&     opam install 
--yes oasis' returned a non-zero code: 1
    ```


> Golang: do something with context.Context
> -----------------------------------------
>
>                 Key: THRIFT-4448
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4448
>             Project: Thrift
>          Issue Type: Task
>          Components: Go - Library
>    Affects Versions: 0.11.0
>            Reporter: John Boiles
>            Priority: Major
>
> PR Here: https://github.com/apache/thrift/pull/1459
> This patch wires through {{context.Context}} such that it can be used in in 
> {{http.Request}}'s {{WithContext}} method. This allows Thrift HTTP requests 
> to canceled or timed out via the context.
> This patch breaks support for go<1.7 so it's not ready to ship, but I'm 
> hoping to get some direction on this. When does Thrift expect to drop support 
> of go1.7? It looks like the current solution is to duplicate files that need 
> to use {{golang.org/x/net/context}} and add a {{// +build !go1.7}} but 
> duplication seems unsustainable as the {{context}} package is imported more 
> places.
> Go 1.7 was released 15 August 2016. Given Golang has had significant 
> performance improvements in most dot releases, I suspect most production 
> services stay reasonably up to date. Here at Periscope/Twitter we're on 
> go1.9.1, and we're a fairly large organization.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to