BELUGA BEHR created THRIFT-4494:
-----------------------------------
Summary: Increase Java Socket Buffer Size
Key: THRIFT-4494
URL: https://issues.apache.org/jira/browse/THRIFT-4494
Project: Thrift
Issue Type: Improvement
Components: Java - Library
Affects Versions: 0.11.0
Reporter: BELUGA BEHR
{code:title=TSocket.java}
if (isOpen()) {
try {
inputStream_ = new BufferedInputStream(socket_.getInputStream(), 1024);
outputStream_ = new BufferedOutputStream(socket_.getOutputStream(),
1024);
} catch (IOException iox) {
close();
throw new TTransportException(TTransportException.NOT_OPEN, iox);
}
}
{code}
The 1024 buffer size is pretty narrow, especially for modern servers with
TCP/IP send and receive buffers ranging from 16K to 64K. Please remove these
hard coded values and rely on the underlying JVM default buffer sizes: 8Kib on
most implementations.
https://github.com/apache/thrift/blob/19baeefd8c38d62085891d7956349601f79448b3/lib/java/src/org/apache/thrift/transport/TSocket.java
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
