James E. King, III resolved THRIFT-4448.
       Resolution: Fixed
    Fix Version/s: 0.12.0

commit 5785279e2e809f6c56dbbe0eb41d13fb17c88bdd
Author: John Boiles <johnaboi...@gmail.com>
Date: Fri Jan 5 14:37:05 2018 -0800

THRIFT-4448: Golang: do something with context.Context. Remove Go1.6 
Client: go

This closes #1459

> Golang: do something with context.Context
> -----------------------------------------
>                 Key: THRIFT-4448
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4448
>             Project: Thrift
>          Issue Type: Task
>          Components: Go - Library
>    Affects Versions: 0.11.0
>            Reporter: John Boiles
>            Assignee: James E. King, III
>            Priority: Major
>             Fix For: 0.12.0
> PR Here: https://github.com/apache/thrift/pull/1459
> This patch wires through {{context.Context}} such that it can be used in in 
> {{http.Request}}'s {{WithContext}} method. This allows Thrift HTTP requests 
> to canceled or timed out via the context.
> This patch breaks support for go<1.7 so it's not ready to ship, but I'm 
> hoping to get some direction on this. When does Thrift expect to drop support 
> of go1.7? It looks like the current solution is to duplicate files that need 
> to use {{golang.org/x/net/context}} and add a {{// +build !go1.7}} but 
> duplication seems unsustainable as the {{context}} package is imported more 
> places.
> Go 1.7 was released 15 August 2016. Given Golang has had significant 
> performance improvements in most dot releases, I suspect most production 
> services stay reasonably up to date. Here at Periscope/Twitter we're on 
> go1.9.1, and we're a fairly large organization.

This message was sent by Atlassian JIRA

Reply via email to