ASF GitHub Bot commented on THRIFT-3916:

Github user bananer commented on the issue:

    @jeking3 This is a well-intended change but I think it is not implemented 
correctly and will break error handling for users.
    In some places in the compiler the input to `render_recv_throw` already is 
a proper `Error` (the JS exception class), e.g. 
    This is not the case for other places:
    The proper way of doing this would be to inspect all usages of 
`render_recv_throw` to see if the argument needs to be wrapped in `new 
Error(…)`. Still then, this could break error handling that relies on these 
cases being strings.

> Errors thrown from JavaScript client is strings and not errors
> --------------------------------------------------------------
>                 Key: THRIFT-3916
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3916
>             Project: Thrift
>          Issue Type: Bug
>          Components: JavaScript - Compiler
>            Reporter: Simen Bekkhus
>            Priority: Minor
>              Labels: javascript
> In JavaScript, you can {{throw}} any object, including strings, but to get 
> stack traces one should throw {{Errors}}.
> The generated JS code throws the error string directly, instead of wrapping 
> it in {{new Error}}.
> Node core _only_ rejects with/throws Errors, never strings, and Thrift should 
> follow the same standard.
> https://nodejs.org/api/errors.html#errors_class_error
> {quote}
> All errors generated by Node.js, including all System and JavaScript errors, 
> will either be instances of, or inherit from, the Error class.
> {quote}
> PR for the change [here|https://github.com/apache/thrift/pull/1075].

This message was sent by Atlassian JIRA

Reply via email to