Github user ozymaxx commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/1496#discussion_r174687128
  
    --- Diff: test/py/RunClientServer.py ---
    @@ -298,7 +300,11 @@ def main():
         print('----------------')
         for genpydir in generated_dirs:
             for script in SCRIPTS:
    -            runScriptTest(options.libdir, options.gen_base, genpydir, 
script)
    +            # The MSVC 2013 C++ compiler stores the double literals 
differently from
    +            # the MSVC 2015 and G++ compilers, so the 
TestRenderedDoubleConstants test
    +            # fails on the VMs with the MSVC2013 configuration
    +            if not (script == 'TestRenderedDoubleConstants.py' and 
options.msvc_profile == 'MSVC2013'):
    +                runScriptTest(options.libdir, options.gen_base, genpydir, 
script)
    --- End diff --
    
    and here @jeking3 


---

Reply via email to