[
https://issues.apache.org/jira/browse/THRIFT-4516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16400457#comment-16400457
]
ASF GitHub Bot commented on THRIFT-4516:
----------------------------------------
GitHub user dcelasun opened a pull request:
https://github.com/apache/thrift/pull/1507
THRIFT-4516: Fix "go vet" warnings for Go 1.10
Opening this here because my free Travis account has its builds killed
after 50 minutes.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dcelasun/thrift THRIFT-4516
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1507.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1507
----
commit a9efd1abd4fd4862d8e967ec207015af79494b6c
Author: D. Can Celasun <can@...>
Date: 2018-03-15T11:52:37Z
THRIFT-4516: Fix "go vet" warnings for Go 1.10
Client: go
----
> Add support for go 1.10
> -----------------------
>
> Key: THRIFT-4516
> URL: https://issues.apache.org/jira/browse/THRIFT-4516
> Project: Thrift
> Issue Type: Improvement
> Components: Go - Library
> Affects Versions: 0.11.0
> Environment: ubuntu-artful (using go 1.10 instead of 1.9)
> Reporter: James E. King, III
> Assignee: Can Celasun
> Priority: Major
>
> Currently go 1.10 has additional type checking on format strings that prevent
> thrift from compiling and running tests. We are limited to go 1.9 until this
> is resolved.
> Example:
> {noformat}
> thrift/protocol_test.go:442: Errorf format %s has arg thelen of wrong type int
> thrift/protocol_test.go:447: Errorf format %q has arg v of wrong type float64
> thrift/protocol_test.go:451: Errorf format %q has arg v of wrong type float64
> thrift/protocol_test.go:454: Errorf format %q has arg value of wrong type
> float64
> thrift/protocol_test.go:482: Errorf format %s has arg thelen of wrong type int
> thrift/protocol_test.go:491: Errorf format %d has arg v of wrong type string
> gopath/src/dontexportrwtest/compile_test.go:32: Sprintf format %v arg s.read
> is a func value, not called
> gopath/src/dontexportrwtest/compile_test.go:33: Sprintf format %v arg s.write
> is a func value, not called
> gopath/src/dontexportrwtest/compile_test.go:36: Sprintf format %v arg is.read
> is a func value, not called
> gopath/src/dontexportrwtest/compile_test.go:37: Sprintf format %v arg
> is.write is a func value, not called{noformat}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
