[
https://issues.apache.org/jira/browse/THRIFT-4524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16406330#comment-16406330
]
ASF GitHub Bot commented on THRIFT-4524:
----------------------------------------
GitHub user stephenstarkie opened a pull request:
https://github.com/apache/thrift/pull/1512
Fix for THRIFT-4524
Also fixed up the project files to include quoted Program Files paths
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stephenstarkie/thrift THRIFT-4524
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1512.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1512
----
commit 0cf5f5abe7fdb8e901918806f4af26a8bf581568
Author: Stephen Starkie <stephen@...>
Date: 2018-03-20T13:28:40Z
Fix for THRIFT-4524
Also fixed up the project files to include quoted Program Files paths
----
> .NET Core Server doesn't close properly when cancelled
> ------------------------------------------------------
>
> Key: THRIFT-4524
> URL: https://issues.apache.org/jira/browse/THRIFT-4524
> Project: Thrift
> Issue Type: Bug
> Components: .NETCore - Library
> Affects Versions: 0.11.0
> Environment: Windows 10 Surface Pro 4. Xamarin.Forms app. .NET
> Standard 2.0 libraries.
> Reporter: Stephen Starkie
> Priority: Major
> Original Estimate: 12h
> Remaining Estimate: 12h
>
> My code starts a server with a cancellation token and then later stops it by
> triggering the token. When it does, the server fails to close cleanly and my
> code cannot then start another server on the same port. The problem is that
> the Task which is responsible for opening and closing the connection in
> AsyncBaseServer throws a TokenCancelationException in the Task.Delay call
> which is not caught and therefore bombs out the task without closing the
> socket. I will raise a pull request with a fix.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
