[
https://issues.apache.org/jira/browse/THRIFT-4358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16406879#comment-16406879
]
ASF GitHub Bot commented on THRIFT-4358:
----------------------------------------
GitHub user jeking3 opened a pull request:
https://github.com/apache/thrift/pull/1513
THRIFT-4358: add unix domain socket option to ruby cross tests
This is the first time I've tried to use ruby with any seriousness. I like
the unit test framework (rspec) -
very descriptive and the mocking is so damn easy compared to C++.
In addition to adding domain socket support to the test harness for client
and server (there was already an implementation in the library), the ruby test
server has a new line of code that's neat:
puts "Starting TestServer #{@server.to_s}"
which turns into, for example:
Starting TestServer
threaded(server(binary(buffered(domain(/tmp/ThriftTest.thrift.57621)))))
or for a socket test:
Starting TestServer threaded(server(compact(framed(socket(:36653)))))
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jeking3/thrift THRIFT-4358
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1513.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1513
----
commit 971719d13e84aac03037b4afae4c7916661ee371
Author: James E. King III <jking@...>
Date: 2018-03-20T19:06:08Z
THRIFT-4358: add unix domain socket option to ruby cross tests
----
> Add unix domain sockets in ruby to cross test - code exists
> -----------------------------------------------------------
>
> Key: THRIFT-4358
> URL: https://issues.apache.org/jira/browse/THRIFT-4358
> Project: Thrift
> Issue Type: Test
> Components: Test Suite
> Affects Versions: 0.10.0
> Environment: docker ubuntu-xenial; autoconf
> Reporter: James E. King, III
> Priority: Minor
>
> I see a unix domain socket class in the ruby transport directory but no cross
> test enabled for it.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
