[
https://issues.apache.org/jira/browse/THRIFT-4535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16420863#comment-16420863
]
ASF GitHub Bot commented on THRIFT-4535:
----------------------------------------
GitHub user cwe1ss opened a pull request:
https://github.com/apache/thrift/pull/1524
THRIFT-4535: XML docs; code cleanup (tabs->spaces; String->string)
As discussed in
[THRIFT-4535](https://issues.apache.org/jira/browse/THRIFT-4535) we'd like to
go back to just one .NET library that supports .NET framework (including Mono)
AND .NET Core.
As I had to learn about the library before doing some actual changes, I
updated the files to contain proper XML comments (which can be used for
IntelliSense) and I did some code cleanup. I did NOT change any code.
Feel free to close this PR, if you prefer to not have such a cleanup commit
(for the sake of better git file history).
/cc @Jens-G @jeking3
PS: I'll submit actual code changes once this PR is merged or rejected.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cwe1ss/thrift cweiss/csharp
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1524.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1524
----
commit 3ea256cd578e729759dfcd59698133f0cecc6729
Author: Christian Weiss <christian@...>
Date: 2018-03-30T19:26:04Z
THRIFT-4535: XML docs; code cleanup (tabs->spaces; String->string)
----
> Current state and future of .NET libraries ("csharp" and "netcore")?
> --------------------------------------------------------------------
>
> Key: THRIFT-4535
> URL: https://issues.apache.org/jira/browse/THRIFT-4535
> Project: Thrift
> Issue Type: Question
> Components: C# - Library, netcore - Library
> Reporter: Christian Weiss
> Priority: Major
>
> Hi,
> We are trying to use Thrift in one of our projects but we ran into some very
> fundamental issues:
> * The "csharp" project does not target ".NET Standard" and there's only a
> very old release on nuget.org ( if [https://www.nuget.org/packages/Thrift/]
> is the official one).
> * The "netcore" project does target ".NET Standard" but there's no release
> yet ( https://issues.apache.org/jira/browse/THRIFT-4512 ) and it also has a
> dependency on ASP.NET Core (
> https://issues.apache.org/jira/browse/THRIFT-4534 ) which makes it unusable
> in non-web projects.
> I'm wondering why there even are 2 separate projects for .NET? It's important
> to understand that ".NET Core" is not a new programming API - It's just a new
> platform - very similar to Silverlight, Mono, Windows Phone. This means that
> it would also be possible to support .NET Core and the new ".NET Standard"
> (which represents a common set of APIs for all platforms) with the existing
> "csharp" project.
> Was this a deliberate decision - e.g. to make the "netcore" code the official
> successor of the "csharp" code?
> Would you be interested in merging the code back into one library? I'd be
> willing to help if you want!
> It would be great to get one proper, up to date and official .NET library
> soon as there's already quite a lot of weird forks on NuGet.org:
> https://www.nuget.org/packages?q=Thrift
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
