James E. King, III created THRIFT-4547: ------------------------------------------
Summary: Finish the conversion to native swift Key: THRIFT-4547 URL: https://issues.apache.org/jira/browse/THRIFT-4547 Project: Thrift Issue Type: Story Components: Swift - Library Affects Versions: 0.12.0 Reporter: James E. King, III Assignee: Chris Simpson Support for Swift-3 was added in THRIFT-3773, however this work needs to be completed. Are there breaking changes? {quote}No/Yes? The compiler is written to allow for the Old Cocoa/Swift with a compiler flag, so anyone still using swift 1 or 2 should still be able to use the Cocoa style generator but will have to use a compiler flag {quote} Are they documented? {quote}I don't believe thats documented anywhere {quote} Is it already running in the cross test or is that future work? {quote}No tests written for this, that is future work {quote} Can this be exercised in the Travis CI build environment? (make check, make cross?) {quote}Should be exercisable in Travis though no tests currently {quote} Can I add swift support to Ubuntu Xenial and Artful? {quote}I'm not sure where the Swift compiler support for Xenial and Artful currently is, but should be available. {quote} What minimum and maximum versions are known supported? {quote}Given backwards compatibility with Cocoa/Swift generator this should work with all Swift versions v1 through v4 (for Swift 1 and 2, the Cocoa library which is Obj-C is required along with the cocoa flag when generating code, for Swift 3+ the dedicated Swift library is required) {quote} Has the LANGUAGES.md file been updated? {quote}LANGUAGES.md has not been updated {quote} Has the build/docker/README.md file been updated? {quote}build/docker/README.md have not been updated {quote} Is this supposed to replace the cocoa implementation? Should that be removed? {quote}The cocoa implementation is separate from this implementation. The Cocoa compiler/libraries exist for Obj-C, and Swift 1 & 2, whereas Swift 3+ operate independently without Cocoa (as Swift 3 and up can run on Linux without Obj-C runtime/libraries). That being said the old Swift/Cocoa compiler is "gone/removed" and there is "only 1 Swift compiler" given the old Swift/Cocoa compiler is integrated in this as a compiler flag {quote} -- This message was sent by Atlassian JIRA (v7.6.3#76005)