[
https://issues.apache.org/jira/browse/THRIFT-4548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16432315#comment-16432315
]
ASF GitHub Bot commented on THRIFT-4548:
----------------------------------------
jeking3 commented on issue #1535: THRIFT-4548: Supporting
TBinaryProtocolAccelerated protocol when using TMultiplexedProcessor in Python
URL: https://github.com/apache/thrift/pull/1535#issuecomment-380110932
I added multi support to the python cross test client and I have multi,
multic, multij working in the python TestClient against various servers.
It looks like multiplexed doesn't work with accel or accelc however. Do the
accelerated protocol implementations have a different interface? Forgive me
but I am not a python expert. Here is the error I am seeing:
```
ERROR: testVoid (__main__.MultiplexedAcceleratedBinaryTest)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/thrift/src/test/py/TestClient.py", line 75, in testVoid
self.client.testVoid()
File "/thrift/src/test/py/gen-py/ThriftTest/ThriftTest.py", line 324, in
testVoid
self.send_testVoid()
File "/thrift/src/test/py/gen-py/ThriftTest/ThriftTest.py", line 330, in
send_testVoid
args.write(self._oprot)
File "/thrift/src/test/py/gen-py/ThriftTest/ThriftTest.py", line 1695, in
write
oprot.trans.write(oprot._fast_encode(self, [self.__class__,
self.thrift_spec]))
File
"/thrift/src/lib/py/build/lib.linux-x86_64-2.7/thrift/protocol/TProtocolDecorator.py",
line 40, in <lambda>
return lambda *args, **kwargs: self._wrap(member, args, kwargs)
File
"/thrift/src/lib/py/build/lib.linux-x86_64-2.7/thrift/protocol/TProtocolDecorator.py",
line 49, in _wrap
result = func(self.protocol, *args, **kwargs)
TypeError: function takes exactly 2 arguments (3 given)
```
Fixing this would accomplish your goal of making them work together while
allowing for decoration with other protocols. I suspect you ran into this and
that led you to the PR submitted?
I will let you know when the test client is merged, then if you can make the
test client work with the accelerated protocols and remove the failing tests
from the known test failures, we'll have a viable solution with tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Supporting TBinaryProtocolAccelerated protocol when using
> TMultiplexedProcessor in Python
> -----------------------------------------------------------------------------------------
>
> Key: THRIFT-4548
> URL: https://issues.apache.org/jira/browse/THRIFT-4548
> Project: Thrift
> Issue Type: Bug
> Reporter: Balazs Kemenes
> Priority: Major
>
> Supporting TBinaryProtocolAccelerated protocol when using
> TMultiplexedProcessor in Python
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
