[
https://issues.apache.org/jira/browse/THRIFT-4532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16443163#comment-16443163
]
ASF GitHub Bot commented on THRIFT-4532:
----------------------------------------
bgedik commented on issue #1541: THRIFT-4532: Do not update previously
generated output files if the contents have not changed
URL: https://github.com/apache/thrift/pull/1541#issuecomment-382522041
In that case, this will break binary compatibility. Because, in C++,
changing the type of a function parameter in a shared library API will require
a recompilation of the dependent applications. Here is a good list of do's and
don'ts for binary compatibility:
https://community.kde.org/Policies/Binary_Compatibility_Issues_With_C%2B%2B
It says 'changing any of the types of the arguments in the parameter list,
including changing the const/volatile qualifiers of the existing parameters
(instead, add a new method)'
@jeking3 If this is really a concern, there is a simple solution to this.
In ``t_oop_generator`` you can keep the old versions as overload, forwarding
the calls to the new versions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Avoid updating Thrift compiler generated code if the output has not changed
> ---------------------------------------------------------------------------
>
> Key: THRIFT-4532
> URL: https://issues.apache.org/jira/browse/THRIFT-4532
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (General)
> Affects Versions: 0.11.0
> Reporter: Buğra Gedik
> Priority: Minor
> Fix For: 0.12.0
>
>
> We would like to contribute an improvement to the Thrift compiler that would
> avoid regenerating target file(s) if they are going to be exactly the same as
> the ones already present in the same place. This will help when running the
> Thrift compiler in our build, especially in recursive mode.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
