[
https://issues.apache.org/jira/browse/THRIFT-4577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16499358#comment-16499358
]
ASF GitHub Bot commented on THRIFT-4577:
----------------------------------------
nsuke opened a new pull request #1560: THRIFT-4577 Outdated cipher string in
python unit test
URL: https://github.com/apache/thrift/pull/1560
`test_ciphers` fails if system SSL doesn't support "DES-CBC3-SHA" which is
quite old.
Adding an additional modern cipher fixes it.
Also fixes a bug where unit test execution hanged forever on SSL
initialization failure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Outdated cipher string in python unit test
> ------------------------------------------
>
> Key: THRIFT-4577
> URL: https://issues.apache.org/jira/browse/THRIFT-4577
> Project: Thrift
> Issue Type: Bug
> Components: Python - Library
> Affects Versions: 0.11.0
> Environment: OpenSSL 1.1.0h
> Reporter: Aki Sukegawa
> Assignee: Aki Sukegawa
> Priority: Minor
>
>
> test_ciphers fails if system SSL doesn't support "DES-CBC3-SHA" which is
> quite old.
> Adding an additional modern cipher fixes it.
> {code:java}
> ======================================================================
> ERROR: test_ciphers (__main__.TSSLSocketTest)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File
> "/data/x/repo/thrift/lib/py/build/lib.linux-x86_64-3.6/thrift/transport/TSSLSocket.py",
> line 281, in _do_open
> return self._wrap_socket(plain_sock)
> File
> "/data/x/repo/thrift/lib/py/build/lib.linux-x86_64-3.6/thrift/transport/TSSLSocket.py",
> line 179, in _wrap_socket
> self.ssl_context.set_ciphers(self.ciphers)
> ssl.SSLError: ('No cipher can be selected.',)
>
> During handling of the above exception, another exception occurred:
>
> Traceback (most recent call last):
> File "test/test_sslsocket.py", line 268, in test_ciphers
> self._assert_connection_success(server, ca_certs=SERVER_CERT,
> ciphers=TEST_CIPHERS)
> File "test/test_sslsocket.py", line 156, in _assert_connection_success
> client.open()
> File
> "/data/x/repo/thrift/lib/py/build/lib.linux-x86_64-3.6/thrift/transport/TSSLSocket.py",
> line 289, in open
> super(TSSLSocket, self).open()
> File
> "/data/x/repo/thrift/lib/py/build/lib.linux-x86_64-3.6/thrift/transport/TSocket.py",
> line 101, in open
> handle = self._do_open(family, socktype)
> File
> "/data/x/repo/thrift/lib/py/build/lib.linux-x86_64-3.6/thrift/transport/TSSLSocket.py",
> line 286, in _do_open
> raise TTransportException(TTransportException.NOT_OPEN, msg)
> thrift.transport.TTransport.TTransportException: failed to initialize
> SSL{code}
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
