[
https://issues.apache.org/jira/browse/THRIFT-4578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16504707#comment-16504707
]
ASF GitHub Bot commented on THRIFT-4578:
----------------------------------------
jeking3 closed pull request #1562: THRIFT-4578 Move `TAsyncProtocolProcessor`
into main thrift library
URL: https://github.com/apache/thrift/pull/1562
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/lib/cpp/CMakeLists.txt b/lib/cpp/CMakeLists.txt
index 734af72d53..1ed0bfadfe 100755
--- a/lib/cpp/CMakeLists.txt
+++ b/lib/cpp/CMakeLists.txt
@@ -28,6 +28,7 @@ set( thriftcpp_SOURCES
src/thrift/TApplicationException.cpp
src/thrift/TOutput.cpp
src/thrift/async/TAsyncChannel.cpp
+ src/thrift/async/TAsyncProtocolProcessor.cpp
src/thrift/async/TConcurrentClientSyncInfo.h
src/thrift/async/TConcurrentClientSyncInfo.cpp
src/thrift/concurrency/ThreadManager.cpp
@@ -140,7 +141,6 @@ set( thriftcppnb_SOURCES
src/thrift/server/TNonblockingServer.cpp
src/thrift/transport/TNonblockingServerSocket.cpp
src/thrift/transport/TNonblockingSSLServerSocket.cpp
- src/thrift/async/TAsyncProtocolProcessor.cpp
src/thrift/async/TEvhttpServer.cpp
src/thrift/async/TEvhttpClientChannel.cpp
)
diff --git a/lib/cpp/Makefile.am b/lib/cpp/Makefile.am
index ff3be5d3ca..83ccd9b6f0 100755
--- a/lib/cpp/Makefile.am
+++ b/lib/cpp/Makefile.am
@@ -70,6 +70,7 @@ libthrift_la_SOURCES = src/thrift/TApplicationException.cpp \
src/thrift/TOutput.cpp \
src/thrift/VirtualProfiling.cpp \
src/thrift/async/TAsyncChannel.cpp \
+ src/thrift/async/TAsyncProtocolProcessor.cpp \
src/thrift/async/TConcurrentClientSyncInfo.cpp \
src/thrift/concurrency/ThreadManager.cpp \
src/thrift/concurrency/TimerManager.cpp \
@@ -116,7 +117,6 @@ libthrift_la_SOURCES += src/thrift/concurrency/Mutex.cpp \
endif
libthriftnb_la_SOURCES = src/thrift/server/TNonblockingServer.cpp \
- src/thrift/async/TAsyncProtocolProcessor.cpp \
src/thrift/async/TEvhttpServer.cpp \
src/thrift/async/TEvhttpClientChannel.cpp
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Move `TAsyncProtocolProcessor` into main thrift library
> -------------------------------------------------------
>
> Key: THRIFT-4578
> URL: https://issues.apache.org/jira/browse/THRIFT-4578
> Project: Thrift
> Issue Type: Improvement
> Components: C++ - Library
> Affects Versions: 0.11.0
> Reporter: Stefan Bolus
> Priority: Minor
> Fix For: 0.12.0
>
>
> Currently, when using asynchronous `cob_style` servers with Thrift, linking
> the `thriftnb` library is mandatory to have the definitions of the class
> `TAsyncProtocolProcessor`. This implies linking against `libevent` for the
> Evhttp async. client and server. When using custom transports like ZeroMQ,
> `libevent` is not necessary and thus, using it should be optional.
> The easiest way so solve the issues seems to move `TAsyncProtocolProcessor`
> to the `thrift` library itself. At least for the server side. I haven't
> checked the client side yet.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
