[
https://issues.apache.org/jira/browse/THRIFT-3950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16531316#comment-16531316
]
ASF GitHub Bot commented on THRIFT-3950:
----------------------------------------
jeking3 commented on issue #1568: THRIFT-3950: Memory leak while calling oneway
methods
URL: https://github.com/apache/thrift/pull/1568#issuecomment-402145256
Instructions for running cross tests in a docker container can be found in
build/docker/README.md. The cross tests were not the ones that failed. Also,
oneway thrift APIs do not process responses. In fact the code generator for
oneway will emit a send method which pushes the message out and then is done.
Sending a response may actually confuse some implementations. If you send a
oneway then a twoway right after it, will the twoway response that is read off
the wire actually try to consume the oneway response you added here? I think
so, and things will break.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Memory leak while calling oneway method
> ---------------------------------------
>
> Key: THRIFT-3950
> URL: https://issues.apache.org/jira/browse/THRIFT-3950
> Project: Thrift
> Issue Type: Bug
> Components: Node.js - Compiler
> Affects Versions: 0.9.3
> Reporter: Sangmin Yoon
> Priority: Major
>
> When you call oneway methods in Node.js, Service._reqs object is bloated.
> There is no chance to 'delete this._reqs[rseqid];' because no return from
> server.
> Also Connection.seqId2Service is bloated.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)