[
https://issues.apache.org/jira/browse/THRIFT-4614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16570934#comment-16570934
]
ASF GitHub Bot commented on THRIFT-4614:
----------------------------------------
msridhar opened a new pull request #1577: THRIFT-4614: Generate missing
@Nullable annotations for Java iterator getters
URL: https://github.com/apache/thrift/pull/1577
THRIFT-4614: Generate @Nullable annotations for Java iterator getters
Client: Java compiler
This is a straightforward, compile-time-safe, backward-compatible change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Generate missing @Nullable annotations for Java iterator getters
> ----------------------------------------------------------------
>
> Key: THRIFT-4614
> URL: https://issues.apache.org/jira/browse/THRIFT-4614
> Project: Thrift
> Issue Type: New Feature
> Components: Java - Compiler
> Reporter: Manu Sridharan
> Priority: Major
>
> This is a brief follow-up to THRIFT-4530. In that change, we neglected to
> generate `@Nullable` annotations for iterator getters for sets and lists.
> They can clearly return null; see
> [here|[https://github.com/apache/thrift/blob/0a2d4587c8cc0a54e4fa8fee9247d088d05b0d65/compiler/cpp/src/thrift/generate/t_java_generator.cc#L2367].]
> The code change is a one-liner. Will open a GitHub PR with the change.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
