[ 
https://issues.apache.org/jira/browse/THRIFT-4619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16577703#comment-16577703
 ] 

ASF GitHub Bot commented on THRIFT-4619:
----------------------------------------

dcelasun commented on issue #1581: THRIFT-4619: Transport SASL Client fo go
URL: https://github.com/apache/thrift/pull/1581#issuecomment-412367074
 
 
   Thanks for the PR, but I don't think this belongs here upstream, especially 
with that third party dependency. As far as I can see, gohive doesn't even have 
a license specified, which is a showstopper on its own.
   
   I recommend maintaining this outside the tree, like 
[Python](https://github.com/cloudera/thrift_sasl) and 
[Perl](https://github.com/Perl-Hadoop/Thrift-SASL) communities do.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Transport SASL Client fo go
> ---------------------------
>
>                 Key: THRIFT-4619
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4619
>             Project: Thrift
>          Issue Type: New Feature
>          Components: Go - Library
>            Reporter: Jaume M
>            Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to