[
https://issues.apache.org/jira/browse/THRIFT-4620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611132#comment-16611132
]
ASF GitHub Bot commented on THRIFT-4620:
----------------------------------------
jeking3 commented on issue #1591: THRIFT-4620: Ensure enough space for for zlib
flush marker
URL: https://github.com/apache/thrift/pull/1591#issuecomment-420393230
I don't believe that the cross test framework will test zlib changes; not
sure if the unit tests do a good job at that either.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> TZlibTransport.cpp doesn't ensure that there is enough space for the zlib
> flush marker in the buffer.
> -----------------------------------------------------------------------------------------------------
>
> Key: THRIFT-4620
> URL: https://issues.apache.org/jira/browse/THRIFT-4620
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 0.9
> Reporter: Dominic Coyne
> Priority: Major
> Labels: c++, zlib
>
> I asked [this
> question|https://stackoverflow.com/questions/51784225/how-does-thrift-handle-zlib-flush-markers-being-split-over-multiple-messages]
> on stack overflow related to a crash that I have been getting with Thrift.
> The problem occurs when using TZlibTransport.cpp. After writing to the buffer
> a few times, we do a flush. If there isn't enough space in cwbuf_ , the
> Thrift flush marker is split across two messages, which causes an error in
> the client, as a deflate stream can't start with a partial flush marker, ff.
> Thrift should assure that there will be enough space in the buffer for the
> complete flush marker, before a deflate.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
