[
https://issues.apache.org/jira/browse/THRIFT-4633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16616475#comment-16616475
]
ASF GitHub Bot commented on THRIFT-4633:
----------------------------------------
Jens-G commented on a change in pull request #1586: THRIFT-4633: .net framework
4.5 Async Client example
URL: https://github.com/apache/thrift/pull/1586#discussion_r217893137
##########
File path: tutorial/csharp.async/README.md
##########
@@ -0,0 +1,8 @@
+# Tutorial Frameword 4.5+ Clent Async
+
+## Setp
+1. thrift -gen csharp:async shared.thrift
+2. thrift -r -gen csharp:async tutorial.thrift
+3. Put it in Tutorial folder
+4. Generated && Run
Review comment:
I have a general problem wth the workflow. IMHO even if we copy the files
manually, we should keep the folder structure. Hence, I'd suggest to have the
user copy the entire gen-csharp folder as is, not single files.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add C# Async Client Tutorial
> ----------------------------
>
> Key: THRIFT-4633
> URL: https://issues.apache.org/jira/browse/THRIFT-4633
> Project: Thrift
> Issue Type: Improvement
> Components: C# - Library
> Affects Versions: 0.11.0
> Reporter: James E. King III
> Assignee: James E. King III
> Priority: Minor
> Fix For: 0.12.0
>
>
> Adding Jira ticket for PR so that it gets into release notes.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
