[
https://issues.apache.org/jira/browse/THRIFT-4624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16616670#comment-16616670
]
ASF GitHub Bot commented on THRIFT-4624:
----------------------------------------
jeking3 commented on issue #1585: THRIFT-4624: Fix refc binary leak
URL: https://github.com/apache/thrift/pull/1585#issuecomment-421745316
Are we all saying the changes in `lib/erl/src/thrift_processor.erl` are good
but the others are unnecessary and may force additional copies of things
unnecessarily? Sorry I don't know erlang and no committer has stepped up to
review. Also `ox-thrift` looks interesting, but does not support as many
transports or protocols as what exists here today and I assume the interface
changed. If it's that much better though (5-10x faster?) we should have a
discussion about bringing that in, if the author desires it. As for this one,
I'm still not sure what to do because nobody made it clear.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Refc binary leak in binary and compact protocols
> ------------------------------------------------
>
> Key: THRIFT-4624
> URL: https://issues.apache.org/jira/browse/THRIFT-4624
> Project: Thrift
> Issue Type: Improvement
> Components: Erlang - Library
> Reporter: something
> Priority: Major
>
> Pattern-matching on large (>64B) Erlang binaries merely produces slices of
> objects on the Refc heap. Therefore Thrift binary and compact protocols
> should clone all binaries they send to upper levels, otherwise there's a
> chance that transport-level messages will be never freed.
> Patch is underway.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
