[
https://issues.apache.org/jira/browse/THRIFT-4637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16616671#comment-16616671
]
ASF GitHub Bot commented on THRIFT-4637:
----------------------------------------
jeking3 closed pull request #1595: THRIFT-4637 C# async mode generates
incorrect code with inherited ser…
URL: https://github.com/apache/thrift/pull/1595
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/compiler/cpp/src/thrift/generate/t_csharp_generator.cc
b/compiler/cpp/src/thrift/generate/t_csharp_generator.cc
index 73ee030aff..bd6331d248 100644
--- a/compiler/cpp/src/thrift/generate/t_csharp_generator.cc
+++ b/compiler/cpp/src/thrift/generate/t_csharp_generator.cc
@@ -2049,7 +2049,7 @@ void
t_csharp_generator::generate_service_server_async(t_service* tservice) {
string extends_processor = "";
if (tservice->get_extends() != NULL) {
extends = type_name(tservice->get_extends());
- extends_processor = extends + ".Processor, ";
+ extends_processor = extends + ".AsyncProcessor, ";
}
indent(f_service_) << "public class AsyncProcessor : " << extends_processor
<< "TAsyncProcessor {" << endl;
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> C# async mode generates incorrect code with inherited services
> ---------------------------------------------------------------
>
> Key: THRIFT-4637
> URL: https://issues.apache.org/jira/browse/THRIFT-4637
> Project: Thrift
> Issue Type: Bug
> Components: C# - Compiler
> Affects Versions: 0.10.0, 0.11.0
> Reporter: Jens Geyer
> Assignee: Jens Geyer
> Priority: Major
>
> If a service interface extends another service, the compiler generates wrong
> code in the {{csharp:async}} case: It inherits from {{Processor}} but should
> inherit from \{{AsyncProcessor}} instead.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
