[
https://issues.apache.org/jira/browse/THRIFT-4645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637358#comment-16637358
]
ASF GitHub Bot commented on THRIFT-4645:
----------------------------------------
james-johnston-thumbtack commented on issue #1602: THRIFT-4645: TCurlClient:
include failure reason in exception
URL: https://github.com/apache/thrift/pull/1602#issuecomment-426749895
No stack information what-so-ever. Here's an example message:
```
TCurlClient: Could not connect to
http://production-users.internal.aws/thrift, Operation timed out after 3001
milliseconds with 0 bytes received
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> TCurlClient: show actual error message when throwing TTransportException
> ------------------------------------------------------------------------
>
> Key: THRIFT-4645
> URL: https://issues.apache.org/jira/browse/THRIFT-4645
> Project: Thrift
> Issue Type: Improvement
> Components: PHP - Library
> Reporter: James Johnston
> Priority: Minor
> Labels: pull-request-available
>
> The TCurlClient does not create a very informative error message when
> throwing TTransportException. In particular, the PHP "curl_error" function
> is a valuable source of information when "curl_exec" fails, and I think it
> would be highly useful to include that message when throwing
> TTransportException.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
