[ https://issues.apache.org/jira/browse/THRIFT-4652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16653026#comment-16653026 ]
Tristian Azura edited comment on THRIFT-4652 at 10/17/18 6:20 AM: ------------------------------------------------------------------ Hi, thank you for the quick reply. True I was inspecting the [compiler source|https://github.com/apache/thrift/blob/master/compiler/cpp/src/thrift/generate/t_go_generator.cc#L2650] to see if I could fix it quickly and I noticed that the proper source strings are there. I'm using the Thrift version installed via homebrew: {code:bash} brew install thrift {code} And {code:bash} λ thrift ~> brew info thrift thrift: stable 0.11.0 (bottled), HEAD Framework for scalable cross-language services development https://thrift.apache.org/ /usr/local/Cellar/thrift/0.11.0 (102 files, 7MB) * Poured from bottle on 2018-10-13 at 17:18:01 From: https://github.com/Homebrew/homebrew-core/blob/master/Formula/thrift.rb {code} Do I have to build Apache Thrift from source to get this fix? was (Author: aztristian): Hi, thank you for the quick reply. True I was inspecting the [compiler source|https://github.com/apache/thrift/blob/master/compiler/cpp/src/thrift/generate/t_go_generator.cc#L2650] to see if I could fix it quickly and I noticed that the proper source strings are there. I'm using the Thrift version installed via homebrew: {code:terminal} brew install thrift {code} And {code:terminal} λ thrift ~> brew info thrift thrift: stable 0.11.0 (bottled), HEAD Framework for scalable cross-language services development https://thrift.apache.org/ /usr/local/Cellar/thrift/0.11.0 (102 files, 7MB) * Poured from bottle on 2018-10-13 at 17:18:01 From: https://github.com/Homebrew/homebrew-core/blob/master/Formula/thrift.rb {code} Do I have to build Apache Thrift from source to get this fix? > Invalid Go source for Services > ------------------------------ > > Key: THRIFT-4652 > URL: https://issues.apache.org/jira/browse/THRIFT-4652 > Project: Thrift > Issue Type: Bug > Components: Go - Compiler > Affects Versions: 0.11.0 > Environment: macOS 10.14 > Go 1.11.1 darwin/amd64 > Thrift 0.11.0 > > > Reporter: Tristian Azura > Priority: Major > > The Go compiler generates invalid code for Thrift services, more > specifically, calls to the `thrift.TProtocol`'s `Flush()` method are missing > the `context.Context` argument: > {noformat} > edam/NoteStore.go:18963:14: not enough arguments in call to oprot.Flush > have () > want (context.Context) > edam/NoteStore.go:18980:16: not enough arguments in call to oprot.Flush > have () > want (context.Context) > edam/NoteStore.go:18999:16: not enough arguments in call to oprot.Flush > have () > want (context.Context) > edam/NoteStore.go:19014:24: not enough arguments in call to oprot.Flush > have () > want (context.Context) > edam/NoteStore.go:19035:16: not enough arguments in call to oprot.Flush > have () > want (context.Context) > edam/NoteStore.go:19054:16: not enough arguments in call to oprot.Flush > have () > want (context.Context) > edam/NoteStore.go:19069:24: not enough arguments in call to oprot.Flush > have () > want (context.Context) > edam/NoteStore.go:19090:16: not enough arguments in call to oprot.Flush > have () > want (context.Context) > edam/NoteStore.go:19111:16: not enough arguments in call to oprot.Flush > have () > want (context.Context) > edam/NoteStore.go:19126:24: not enough arguments in call to oprot.Flush > have () > want (context.Context){noformat} > > I used the following models: > * [https://github.com/evernote/evernote-thrift] > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)