Looking at the diff [1] most changes seem safe to include except da1169d - I'm not familiar enough with JS to comment on that.
Cheers, Can [1] https://github.com/apache/thrift/compare/0.12.0...master On Wed, 7 Nov 2018, at 16:58, James E. King III wrote: > All changes since the branch was taken should be scrutinized, including > build system changes, for inclusion in 0.12.0. > I haven't seen any follow-ups since my review comments on the 0.12.0 build. > > - Jim > > On Wed, Nov 7, 2018 at 6:52 AM Allen George <[email protected]> wrote: > > > Hi all - > > > > I’d like to cherry-pick a couple of PRs for the rust generator to the > > 0.12.0 branch. I know a message was sent about the branch being cut. Has > > packaging started yet? That is, is it too late for these generator changes > > to make it in for 0.12.0? > > > > Thanks, > > Allen > >
