[
https://issues.apache.org/jira/browse/THRIFT-4667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16692220#comment-16692220
]
James E. King III edited comment on THRIFT-4667 at 11/19/18 8:29 PM:
---------------------------------------------------------------------
I'd have no problem with that - access would need to be protected for
multi-thread address if you can call it while the server is running. I had the
ability to add or remove services in THRIFT-66, which never made it into the
project the way I did it, but it was useful. For example you have a basic
service with authentication and then once they authenticate you can enable
services depending on their account status.
It would probably be better to change TMultiplexedProcessor to have safe
methods to add or remove a service.
was (Author: jking3):
I'd have no problem with that - access would need to be protected for
multi-thread address if you can call it while the server is running. I had the
ability to add or remove services in THRIFT-66, which never made it into the
project the way I did it, but it was useful. For example you have a basic
service with authentication and then once they authenticate you can enable
services depending on their account status.
> netcore TMultiplexedProcessor derived processors
> ------------------------------------------------
>
> Key: THRIFT-4667
> URL: https://issues.apache.org/jira/browse/THRIFT-4667
> Project: Thrift
> Issue Type: Improvement
> Components: netcore - Library
> Affects Versions: 0.11.0
> Reporter: J W
> Priority: Minor
>
> Currently we maintain a local version of Thrift because we added an
> `UnregisterProcessor()` method to `TMultiplexedProcessor`. It looks like
> adding this method would break symmetry with the "multiplexed processor"
> found in other languages' implementations.
>
> Instead, how about changing `_serviceProcessorMap` to `protected` so library
> users can create classes that inherit from `TMultiplexedProcessor`?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
