[ 
https://issues.apache.org/jira/browse/THRIFT-3143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16700503#comment-16700503
 ] 

ASF GitHub Bot commented on THRIFT-3143:
----------------------------------------

mustafa-cosar edited a comment on issue #1630: THRIFT-3143: Add nodets support
URL: https://github.com/apache/thrift/pull/1630#issuecomment-442055696
 
 
   I did some improvements to the tests script so most timeouts are fixed.
   
   the `erl-nodets` and `d-nodets` tests fail but their `nodejs` counterparts 
are in `known_failures_Linux.json` so they should be added as well.
   
   There is one test that I couldn't figure out: In `hs-nodets` test, the 
client logs that all the tests are successful and it does call 
`connection.end()`. However it still times out for some reason...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> add typescript directory support
> --------------------------------
>
>                 Key: THRIFT-3143
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3143
>             Project: Thrift
>          Issue Type: New Feature
>          Components: Node.js - Compiler
>            Reporter: Kazuki Yasufuku
>            Priority: Major
>
> Current typescript support is only work for browser, and generated d.ts uses 
> internal module.
> So, it's hard to use for typescript in node.js.
> To solve probrem, I make a pull request that generate typescript code 
> directory.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to