[
https://issues.apache.org/jira/browse/THRIFT-4679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16715002#comment-16715002
]
ASF GitHub Bot commented on THRIFT-4679:
----------------------------------------
griffinmichl commented on issue #1642: THRIFT-4679: Remove unused variable
declaration
URL: https://github.com/apache/thrift/pull/1642#issuecomment-445871911
Any idea how I can get this merged into the thrift npm package?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Duplicate declaration of InputBufferUnderrunError in
> lib/nodejs/lib/thrift/json_protocol.js
> -------------------------------------------------------------------------------------------
>
> Key: THRIFT-4679
> URL: https://issues.apache.org/jira/browse/THRIFT-4679
> Project: Thrift
> Issue Type: Bug
> Components: JavaScript - Library
> Affects Versions: 0.11.0
> Reporter: Griffin Michl
> Assignee: James E. King III
> Priority: Minor
> Labels: easyfix
> Fix For: 1.0
>
> Original Estimate: 10m
> Remaining Estimate: 10m
>
> InputBufferUnderrunError is unnecessarily declared twice in
> `lib/nodejs/lib/thrift/json_protocol.js`. This causes certain compilers to
> break when they attempt to compile code that uses the node thrift library. We
> should remove the first declaration, as it does not do anything.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
