[
https://issues.apache.org/jira/browse/THRIFT-4659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16715706#comment-16715706
]
ASF GitHub Bot commented on THRIFT-4659:
----------------------------------------
jgheewala opened a new pull request #1645: THRIFT-4659 golang race detected
when closing listener socket
URL: https://github.com/apache/thrift/pull/1645
Some helpful tips for a successful Apache Thrift PR:
* Did you test your changes locally or using CI in your fork?
Tested changes locally
* Is the Apache Jira THRIFT ticket identifier in the PR title?
Yes
* Is the Apache Jira THRIFT ticket identifier in the commit message?
Yes
* Did you squash your changes to a single commit?
Yes
* Are these changes backwards compatible? (please say so in PR description)
* Do you need to update the language-specific README?
Client: [go]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> golang race detected when closing listener socket
> -------------------------------------------------
>
> Key: THRIFT-4659
> URL: https://issues.apache.org/jira/browse/THRIFT-4659
> Project: Thrift
> Issue Type: Bug
> Components: Go - Library
> Affects Versions: 0.11.0
> Reporter: Jay Gheewala
> Assignee: Can Celasun
> Priority: Major
> Attachments: THRIFT-4659.diff
>
>
> Race condition is deteced for following write/read
>
> git.apache.org/thrift.git/lib/go/thrift/server_socket.go:119
> git.apache.org/thrift.git/lib/go/thrift.(*TServerSocket).Close()
> git.apache.org/thrift.git/lib/go/thrift/server_socket.go:122
> git.apache.org/thrift.git/lib/go/thrift.(*TServerSocket).Interrupt()
>
> git.apache.org/thrift.git/lib/go/thrift.(*TServerSocket).Accept()
> git.apache.org/thrift.git/lib/go/thrift/server_socket.go:78
> git.apache.org/thrift.git/lib/go/thrift.(*TSimpleServer).innerAccept()
> git.apache.org/thrift.git/lib/go/thrift/simple_server.go:129
> git.apache.org/thrift.git/lib/go/thrift.(*TSimpleServer).AcceptLoop()
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
