[jira] [Created] (THRIFT-4684) Missing namespace and un-used private fields in WCF fault classes when enable WCF in C# code generation

Sun, 23 Dec 2018 05:16:09 -0800 

Shaoyu Zhang created THRIFT-4684:
------------------------------------

             Summary: Missing namespace and un-used private fields in WCF fault 
classes when enable WCF in C# code generation
                 Key: THRIFT-4684
                 URL: https://issues.apache.org/jira/browse/THRIFT-4684
             Project: Thrift
          Issue Type: Bug
          Components: C# - Compiler
    Affects Versions: 0.11.0
            Reporter: Shaoyu Zhang


When WCF is enabled in C# code generation, a commented line is generated:

//using System.ServiceModel;

However, attributes like OperationContract still need this.

Also when generating fields in fault classes, we should follow the same 
behavior in normal struct, otherwise we could generate unused private fields, 
when auto properties are also generated.

Here is a draft fix for the potential bug: 
[https://github.com/zsy056/thrift/commit/d00049d94887fb1bfda1efea5a3efe94ccbad472]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to