[ 
https://issues.apache.org/jira/browse/THRIFT-4709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16731457#comment-16731457
 ] 

BELUGA BEHR commented on THRIFT-4709:
-------------------------------------

I have a patch for this once [THRIFT-4694] is completed.

> Use StandardCharset UTF-8
> -------------------------
>
>                 Key: THRIFT-4709
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4709
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Java - Library
>    Affects Versions: 0.12.0
>            Reporter: BELUGA BEHR
>            Priority: Minor
>
> AS I understand it, starting with Java 1.7, all JVM must support the UTF-8 
> charset.  Prior to JDK 7, it was required to do something like:
> {code:java|title=TJSONProtocol.java}
>     try {
>       byte[] buf = str.getBytes("UTF-8");
>       trans_.write(buf);
>     } catch (UnsupportedEncodingException uex) {
>       throw new TException("JVM DOES NOT SUPPORT UTF-8");
>     }
> {code}
> However, now there is available {{java.nio.charset.StandardCharsets}} which 
> provides the required charsets and therefore there is no longer a need to do 
> a try/catch to encode/decode Strings and UTF-8 byte arrays.  This will save 
> on lines of code and removes the overhead of the try/catch block.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to