[ 
https://issues.apache.org/jira/browse/THRIFT-1386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James E. King III closed THRIFT-1386.
-------------------------------------
       Resolution: Won't Fix
         Assignee: James E. King III
    Fix Version/s:     (was: 1.0)

Closing - inactive for a long time; feel free to reopen with a pull request.

> The toString function can consume less CPU and tests
> ----------------------------------------------------
>
>                 Key: THRIFT-1386
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1386
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Java - Compiler
>    Affects Versions: 0.8
>            Reporter: Verdoïa Laurent
>            Assignee: James E. King III
>            Priority: Minor
>         Attachments: toString.patch
>
>
> The toString member of generates classes don't need:
> 1. to test the isFirst value.
> The compiler allready know it and can handle the last comma himself
> 2. to handle special case for nullable object.
> StrinBuilder is used for create the resulting string.
> This append method always append the string "null" for null objects.
> But the result of append(char[] data) with null is not specified; who care. 
> We don't use it!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to