[
https://issues.apache.org/jira/browse/THRIFT-4732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16740562#comment-16740562
]
James E. King III commented on THRIFT-4732:
-------------------------------------------
One of the changes I am making is to use BUILD_SHARED_LIBS which is the
standard cmake designation for building shared vs. static and getting rid of
the dual mode build, deprecating WITH_(SHARED|STATIC)_LIBS. I'm going to get
to a stopping point here and get a PR out so I am out of this area and you can
move forward more easily.
> increase cmake minimal required version and cleanup cmake scripts
> -----------------------------------------------------------------
>
> Key: THRIFT-4732
> URL: https://issues.apache.org/jira/browse/THRIFT-4732
> Project: Thrift
> Issue Type: Improvement
> Reporter: yuanyuan chen
> Priority: Major
>
> In order to use modern cmake syntax to cleanup building scripts and add
> shared library support on Windows by using [[windows_export_all_symbol|
> https://cmake.org/cmake/help/v3.13/prop_tgt/WINDOWS_EXPORT_ALL_SYMBOLS.html].|https://cmake.org/cmake/help/v3.13/prop_tgt/WINDOWS_EXPORT_ALL_SYMBOLS.html]
> So I think it is a good idea to increase cmake minimal required version.May
> be 3.10 is a good alternative version?
> h1.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
