[
https://issues.apache.org/jira/browse/THRIFT-4732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16740882#comment-16740882
]
yuanyuan chen edited comment on THRIFT-4732 at 1/11/19 11:45 PM:
-----------------------------------------------------------------
I want to use BUILD_SHARED_LIBS too,and I am agree with using cmake 3.5 to
support ubuntu 16.04.
It is better if this work can be done in Saturday or Sunday.
was (Author: cyy):
I want to use BUILD_SHARED_LIBS too,and I am agree with using cmake 3.5 to
support ubuntu 16.04.
It is better if this work can be finished in Saturday or Sunday.
> increase cmake minimal required version and cleanup cmake scripts
> -----------------------------------------------------------------
>
> Key: THRIFT-4732
> URL: https://issues.apache.org/jira/browse/THRIFT-4732
> Project: Thrift
> Issue Type: Improvement
> Reporter: yuanyuan chen
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In order to use modern cmake syntax to cleanup building scripts and add
> shared library support on Windows by using [[windows_export_all_symbol|
> https://cmake.org/cmake/help/v3.13/prop_tgt/WINDOWS_EXPORT_ALL_SYMBOLS.html].|https://cmake.org/cmake/help/v3.13/prop_tgt/WINDOWS_EXPORT_ALL_SYMBOLS.html]
> So I think it is a good idea to increase cmake minimal required version.May
> be 3.10 is a good alternative version?
> h1.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
