[
https://issues.apache.org/jira/browse/THRIFT-2798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16743108#comment-16743108
]
James E. King III commented on THRIFT-2798:
-------------------------------------------
I believe one of the recent PRs removed the CMake windows XP directives and
changed _WINNT_WIN32, but someone needs to look at it. I agree, this can be
removed. We can start removing the checks for stdint.h and just use <cstdint>,
and others. These checks happen in both autoconf and cmake; on Windows the
cmake build does not use the generated config.h either (which is a backlog item
in Jira). Lots to do, glad someone is helping!
> Thrift does not compile on Windows with TARGET_WIN_XP=0
> -------------------------------------------------------
>
> Key: THRIFT-2798
> URL: https://issues.apache.org/jira/browse/THRIFT-2798
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 0.9.1, 0.9.2
> Reporter: Alex Merry
> Priority: Major
>
> To compile with Visual Studio 2013 after defining TARGET_WIN_XP=0 (and
> HAVE_STDINT_H=1), I have to do the following:
> # Remove BoostThreadFactory.cpp and BoostThreadFactory.h from concurrency
> # Add
> \#ifndef WINVER
> \# define WINVER 0x0601
> \#endif
> after
> \#ifndef _WIN32_WINNT
> \# define _WIN32_WINNT 0x0601
> \#endif
> in windows/config.h
> # Remove #include <thrift/transport/PlatformSocket.h> from Thrift.h (or move
> it to after #include <thrift/thrift-config.h>), since it depends on the
> WINVER definition from windows/config.h.
> I'm not sure what the best fix for the boost thread factory thing is (maybe
> #ifdef the file contents based on USE_BOOST_THREAD?), but I think the other
> code changes should go in.
> It may also be worth having
> \#if _MSC_VER >= 1800
> \# define HAVE_STDINT_H
> \#endif
> in windows/config.h.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
