[ 
https://issues.apache.org/jira/browse/THRIFT-4740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16749529#comment-16749529
 ] 

James E. King III commented on THRIFT-4740:
-------------------------------------------

The committers can do this, but I ran into a GitHub glitch.  When I did it, It 
told me to reload the page to try again, and when I clicked on the button it 
gave me, it ended up doing a rebase.

So on the first one, I forgot to squash.  On this one, I remembered, but the 
page was stale by the time I clicked OK and it ended up doing a rebase anyway.  
These are both on me; we don't have to require submitters to squash.

> Use std::chrono for timeout and remove old structures.
> ------------------------------------------------------
>
>                 Key: THRIFT-4740
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4740
>             Project: Thrift
>          Issue Type: Improvement
>          Components: C++ - Library
>    Affects Versions: 0.13.0
>            Reporter: yuanyuan chen
>            Assignee: James E. King III
>            Priority: Major
>             Fix For: 0.13.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Hopefully we can replace windows time functions with chrono eventually.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to