I believe TryFrom has been stabilized in the latest stable release of rust (1.34)?
Kyle Smith -----Original Message----- From: James E. King III <[email protected]> Sent: Friday, June 21, 2019 8:40 AM To: [email protected] Subject: [External] Required rust version? I tried to compile thrift on Ubuntu Bionic with rustc 1.30 on it and it failed: root@6a15337c1e4d:/thrift/src/lib/rs# dpkg -l | grep rust ii libstd-rust-1.30:amd64 1.30.0+dfsg1+llvm-2ubuntu1~18.04.1 amd64 Rust standard libraries ii libstd-rust-dev:amd64 1.30.0+dfsg1+llvm-2ubuntu1~18.04.1 amd64 Rust standard libraries - development files ii rustc 1.30.0+dfsg1+llvm-2ubuntu1~18.04.1 amd64 Rust systems programming language root@6a15337c1e4d:/thrift/src/lib/rs# make Making all in . make[1]: Entering directory '/thrift/src/lib/rs' /usr/bin/cargo build Updating crates.io index Downloading ordered-float v0.5.2 Downloading threadpool v1.7.1 Downloading log v0.4.6 Downloading byteorder v1.3.2 Downloading integer-encoding v1.0.7 Downloading num-traits v0.1.43 Downloading unreachable v1.0.0 Downloading num-traits v0.2.8 Downloading autocfg v0.1.4 Downloading void v1.0.2 Downloading num_cpus v1.10.1 Downloading libc v0.2.58 Downloading cfg-if v0.1.9 Compiling autocfg v0.1.4 Compiling libc v0.2.58 Compiling byteorder v1.3.2 Compiling void v1.0.2 Compiling cfg-if v0.1.9 Compiling integer-encoding v1.0.7 Compiling num-traits v0.2.8 Compiling unreachable v1.0.0 Compiling log v0.4.6 Compiling num_cpus v1.10.1 Compiling threadpool v1.7.1 Compiling num-traits v0.1.43 Compiling ordered-float v0.5.2 Compiling thrift v0.13.0 (/thrift/src/lib/rs) error[E0658]: use of unstable library feature 'try_from' (see issue #33417) --> src/protocol/mod.rs:60:26 | 60 | use std::convert::{From, TryFrom}; | ^^^^^^^ error[E0658]: use of unstable library feature 'try_from' (see issue #33417) --> src/protocol/binary.rs:19:26 | 19 | use std::convert::{From, TryFrom}; | ^^^^^^^ ... Is there a reason why we're requiring unstable library features? Seems like an unusual choice. - Jim * This email was sent from an external source, please use caution and validate the email before opening attachments or clicking on hyperlinks. *
