CHENG GUOZHU created THRIFT-4908:
------------------------------------

             Summary: reader&writer in golang's TBinaryProtocol is not 
neccessary and misleading
                 Key: THRIFT-4908
                 URL: https://issues.apache.org/jira/browse/THRIFT-4908
             Project: Thrift
          Issue Type: Improvement
          Components: Go - Library
    Affects Versions: 0.12.0
            Reporter: CHENG GUOZHU


while reading code in 
[https://github.com/apache/thrift/blob/master/lib/go/thrift/binary_protocol.go]

It seems the reader and writer in TBinaryProtocol is not necessary, because 
this class is serialize/deserialize the struct and write/read the data stream 
via trans, `reader` & `writer` here are duplicated with `trans` in this struct

if it's meaningful, I will submit a patch for this



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Reply via email to