[ 
https://issues.apache.org/jira/browse/THRIFT-5096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17037817#comment-17037817
 ] 

Haochao Zhuang commented on THRIFT-5096:
----------------------------------------

> Thrift allows you to write own customized transports. Did you try that? 

Yes, I get it. Currently, I did so for trace as SkyWalking plugin. This is 
equivalent to that we have modified the protocol, so we need to support both 
the client and the server. I mean, we need to enable this plug-in at the same 
time.
But it is unfriendly to share with the SkyWalking community as a plugin. 

> Otherwise you may consider to share some more details on the feature idea and 
> why you think it is important. You know, it is sometimes hard to read other 
> peoples mind remotely.

Sorry. 
The trace system gets what happens on the client/server, so trace system has to 
inject something on transport to make them a pair.

> Support custom metadata on raw-tcp transport 
> ---------------------------------------------
>
>                 Key: THRIFT-5096
>                 URL: https://issues.apache.org/jira/browse/THRIFT-5096
>             Project: Thrift
>          Issue Type: New Feature
>          Components: Java - Library
>            Reporter: Haochao Zhuang
>            Priority: Major
>
> That likes to enable custom HTTP-header on HTTP transport. Currently, we 
> don't enable custom header/metadata on Raw-TCP transport. And it is important 
> for trace.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to