[
https://issues.apache.org/jira/browse/THRIFT-5084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer reopened THRIFT-5084:
--------------------------------
Sorry, but you need to revise the patch.
{code}
travis_time:start:09aeba87
$ pod lib lint --allow-warnings --swift-version=3
-> Thrift
-> Thrift (0.14.0)
- WARN | keys: Unrecognized `url` key for `license` attribute.
- ERROR | xcodebuild: Returned an unsuccessful exit code. You can use
`--verbose` for more information.
- NOTE | xcodebuild: note: Using new build system
- NOTE | xcodebuild: note: Planning build
- NOTE | xcodebuild: note: Constructing build description
- NOTE | [iOS] xcodebuild: warning: Capabilities for App may not function
correctly because its entitlements use a placeholder team ID. To resolve this,
select a development team in the build settings editor. (in target 'App')
- NOTE | xcodebuild: warning: Swift 3 mode has been deprecated and will
be removed in a later version of Xcode. Please migrate "Thrift" to Swift 4.2
using "Convert > To Current Swift Syntax…" in the Edit menu. (in target
'Thrift')
- NOTE | xcodebuild: warning: Swift 3 mode has been deprecated and will
be removed in a later version of Xcode. Please migrate "App" to Swift 4.2 using
"Convert > To Current Swift Syntax…" in the Edit menu. (in target 'App')
- NOTE | [iOS] xcodebuild: warning: Skipping code signing because the
target does not have an Info.plist file. (in target 'App')
- WARN | xcodebuild:
/Users/travis/build/apache/thrift/lib/swift/Sources/TMultiplexedProcessor.swift:89:5:
warning: expression of type '(String, TMessageType, Int32)' is unused
- WARN | xcodebuild:
/Users/travis/build/apache/thrift/lib/swift/Sources/TProtocolDecorator.swift:37:15:
warning: result of call to 'readMessageBegin()' is unused
- WARN | xcodebuild:
/Users/travis/build/apache/thrift/lib/swift/Sources/TProtocolDecorator.swift:45:15:
warning: result of call to 'readStructBegin()' is unused
- WARN | xcodebuild:
/Users/travis/build/apache/thrift/lib/swift/Sources/TProtocolDecorator.swift:53:15:
warning: result of call to 'readFieldBegin()' is unused
- WARN | xcodebuild:
/Users/travis/build/apache/thrift/lib/swift/Sources/TProtocolDecorator.swift:61:15:
warning: result of call to 'readMapBegin()' is unused
- WARN | xcodebuild:
/Users/travis/build/apache/thrift/lib/swift/Sources/TProtocolDecorator.swift:69:15:
warning: result of call to 'readSetBegin()' is unused
- WARN | xcodebuild:
/Users/travis/build/apache/thrift/lib/swift/Sources/TProtocolDecorator.swift:77:15:
warning: result of call to 'readListBegin()' is unused
- ERROR | xcodebuild:
/Users/travis/build/apache/thrift/lib/swift/Sources/TProtocolDecorator.swift:85:9:
error: ambiguous use of 'read()'
- NOTE | xcodebuild:
/Users/travis/build/apache/thrift/lib/swift/Sources/TProtocol.swift:65:8: note:
found this candidate
- NOTE | xcodebuild:
/Users/travis/build/apache/thrift/lib/swift/Sources/TProtocol.swift:66:8: note:
found this candidate
- NOTE | xcodebuild:
/Users/travis/build/apache/thrift/lib/swift/Sources/TProtocol.swift:67:8: note:
found this candidate
- NOTE | xcodebuild:
/Users/travis/build/apache/thrift/lib/swift/Sources/TProtocol.swift:68:8: note:
found this candidate
- NOTE | xcodebuild:
/Users/travis/build/apache/thrift/lib/swift/Sources/TProtocol.swift:69:8: note:
found this candidate
- NOTE | xcodebuild:
/Users/travis/build/apache/thrift/lib/swift/Sources/TProtocol.swift:70:8: note:
found this candidate
- NOTE | xcodebuild:
/Users/travis/build/apache/thrift/lib/swift/Sources/TProtocol.swift:71:8: note:
found this candidate
- NOTE | xcodebuild:
/Users/travis/build/apache/thrift/lib/swift/Sources/TProtocol.swift:72:8: note:
found this candidate
- ERROR | xcodebuild:
/Users/travis/build/apache/thrift/lib/swift/Sources/TProtocolDecorator.swift:89:9:
error: ambiguous use of 'read()'
- ERROR | xcodebuild:
/Users/travis/build/apache/thrift/lib/swift/Sources/TProtocolDecorator.swift:93:9:
error: ambiguous use of 'read()'
- ERROR | xcodebuild:
/Users/travis/build/apache/thrift/lib/swift/Sources/TProtocolDecorator.swift:97:9:
error: ambiguous use of 'read()'
- ERROR | xcodebuild:
/Users/travis/build/apache/thrift/lib/swift/Sources/TProtocolDecorator.swift:101:9:
error: ambiguous use of 'read()'
- ERROR | xcodebuild:
/Users/travis/build/apache/thrift/lib/swift/Sources/TProtocolDecorator.swift:105:9:
error: ambiguous use of 'read()'
- ERROR | xcodebuild:
/Users/travis/build/apache/thrift/lib/swift/Sources/TProtocolDecorator.swift:109:9:
error: ambiguous use of 'read()'
- ERROR | xcodebuild:
/Users/travis/build/apache/thrift/lib/swift/Sources/TProtocolDecorator.swift:113:9:
error: ambiguous use of 'read()'
[!] Thrift did not pass validation, due to 9 errors.
You can use the `--no-clean` option to inspect any issue.
travis_time:end:09aeba87:start=1582461901837235000,finish=1582461929245148000,duration=27407913000,event=script
The command "pod lib lint --allow-warnings --swift-version=3" exited with 1.
{code}
> Swift: Server-side support for Multiplexing Services
> ----------------------------------------------------
>
> Key: THRIFT-5084
> URL: https://issues.apache.org/jira/browse/THRIFT-5084
> Project: Thrift
> Issue Type: Improvement
> Components: Swift - Library
> Affects Versions: 0.13.0
> Reporter: Alexander Edge
> Assignee: Alexander Edge
> Priority: Minor
> Labels: multiplex
> Fix For: 0.14.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The Swift library features {{TMultiplexedProtocol}} but not
> {{TMultiplexedProcessor}}, which is required for use server-side.
> I've added {{TMultiplexedProcessor}}, following the same patterns as the
> other language libraries. -I've marked this issue as _Breaking-Change_ since
> it removes the {{associatedType}} from the {{TProcessor}} protocol-. I've
> removed the {{associatedType}} from {{TProcessor}} otherwise it makes it
> impossible for {{TMultiplexedProcessor}} to implement {{TProcessor}}. By
> definition it should support processors of multiple services, not a single
> service.
> I've added tests which require a change to {{Package.swift}} to run using
> {{swift test}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
