[
https://issues.apache.org/jira/browse/THRIFT-5067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17064274#comment-17064274
]
Jens Geyer edited comment on THRIFT-5067 at 3/22/20, 1:27 PM:
--------------------------------------------------------------
{color:#24292e}You will run into the same problem when you use anything else
that gives a valid file name but not a valid #ifdef identifier. I'll commit
this, but it does not really solve the general problem.{color}
{color:#24292e}Therefore, I leave the ticket open intentionally, as the problem
is only partially solved.{color}
was (Author: jensg):
{color:#24292e}You will run into the same problem when you use anything else
that gives a valid file name but not a valid #ifdef identifier. I'll commit
this, but it does not really solve the general problem.{color}
> Invalid Cpp generated for include guards from valid Thrift IDL when the file
> name has characters that are not valid in a c++ #define
> ------------------------------------------------------------------------------------------------------------------------------------
>
> Key: THRIFT-5067
> URL: https://issues.apache.org/jira/browse/THRIFT-5067
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Compiler
> Reporter: Michaël Melchiore
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> I classify this as a bug as valid Thrift file silently generates invalid C++
> code. Feel free to change the issue type if you disagree.
> I use a a namespace hierarchy for my Thrift data model. When writing nested
> namespaces, I tend to represent to parent-child relationship of these
> namespaces in their the containing file names.
> So for example, I have the following relationship:
> * namespace "base" defined in file "base.thrift"
> * name "base.net" defined in file "base.net.thrift"
> Note that this convention of using dots to separate namespaces seems
> consistent with Thrift namespace syntax.
> The generated Cpp header for the base.net namespace does not compile: the
> include guard variable name uses the dot which is not valid C++ syntax.
> I think the Cpp compiler should replace dots with underscores when generating
> the include guard.
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
