[
https://issues.apache.org/jira/browse/THRIFT-5180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17089967#comment-17089967
]
Jens Geyer commented on THRIFT-5180:
------------------------------------
TBH, about the required non-empty URL ... I had the same thoughts. Said nothing
because introducing breaking change vs added value - is it worth it?
Would love to hear other opinions.
> THttpClient requires a path when used with domain sockets
> ---------------------------------------------------------
>
> Key: THRIFT-5180
> URL: https://issues.apache.org/jira/browse/THRIFT-5180
> Project: Thrift
> Issue Type: Improvement
> Components: C++ - Library
> Affects Versions: 0.13.0
> Reporter: Mario Emmenlauer
> Priority: Minor
>
> When using the THttpClient with domain sockets, everything seems to work well
> as long as a service path is set in the client, for example
> {code}
> // create aTransport as a unix domain socket, then do:
> vTransport =
> std::make_shared<apache::thrift::transport::THttpClient>(aTransport,
> "localhost", "x");
> {code}
> But when the path is empty, the transport fails with
> {code}
> Thrift: Mon Apr 20 16:10:22 2020 TConnectedClient died: Bad Status: POST
> ThriftClient::ping(): Caught std::exception with message Could not refill
> buffer while calling the ping() method.
> {code}
> The error message "Could not refill buffer" points to a problem somewhere in
> the read method of THttpTransport.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
