dcelasun commented on pull request #2085: URL: https://github.com/apache/thrift/pull/2085#issuecomment-618671507
Thanks for the PR! Couple of things before this can be merged: - Please open a Jira ticket and discuss why this change is needed. It's not obvious to me why we should preallocate pointer fields. - Please add a test case. - Please squash your commits and write a commit message that follows the [contribution guidelines](https://github.com/apache/thrift/blob/master/CONTRIBUTING.md#github-pull-requests). I'm going to close this now. After discussion on Jira, we can reopen if necessary. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
