[
https://issues.apache.org/jira/browse/THRIFT-4923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer closed THRIFT-4923.
------------------------------
Assignee: Jens Geyer
Resolution: Invalid
Logging such messages is perfectly legit. Furthermore, the proposed "solution"
would not even fix the claim made.
> An information leakage from TIOStreamTransport
> ----------------------------------------------
>
> Key: THRIFT-4923
> URL: https://issues.apache.org/jira/browse/THRIFT-4923
> Project: Thrift
> Issue Type: Bug
> Components: Java - Library
> Affects Versions: 0.11.0, 0.12.0
> Environment: Ubuntu 16.04.3 LTS
> Open JDK version "1.8.0_191" build 25.191-b12
> Reporter: xiaoqin.fu
> Assignee: Jens Geyer
> Priority: Major
>
> In org.apache.thrift.transport.TIOStreamTransport,
> public void close() {
> if (inputStream_ != null) {
> try {
> inputStream_.close();
> } catch (IOException iox) {
> LOGGER.warn("Error closing input stream.", iox);
> }
> inputStream_ = null;
> }
> if (outputStream_ != null) {
> try {
> outputStream_.close();
> } catch (IOException iox) {
> LOGGER.warn("Error closing output stream.", iox);
> }
> outputStream_ = null;
> }
> }
> Sensitive information about socket input stream or output stream is leaked.
> The LOGGER.isWarnEnabled() conditional statement should be added:
> public void close() {
> if (inputStream_ != null) {
> try {
> inputStream_.close();
> } catch (IOException iox) {
> if (LOGGER.isWarnEnabled())
> LOGGER.warn("Error closing input stream.", iox);
> }
> inputStream_ = null;
> }
> if (outputStream_ != null) {
> try {
> outputStream_.close();
> } catch (IOException iox) {
> if (LOGGER.isWarnEnabled())
> LOGGER.warn("Error closing output stream.", iox);
> }
> outputStream_ = null;
> }
> }
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
