[
https://issues.apache.org/jira/browse/THRIFT-5234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer resolved THRIFT-5234.
--------------------------------
Fix Version/s: 0.14.0
Resolution: Fixed
> Fix a number of js/ts generation issues
> ---------------------------------------
>
> Key: THRIFT-5234
> URL: https://issues.apache.org/jira/browse/THRIFT-5234
> Project: Thrift
> Issue Type: Bug
> Components: JavaScript - Compiler
> Reporter: Jens Geyer
> Assignee: Jens Geyer
> Priority: Major
> Fix For: 0.14.0
>
>
> _The following text stems from the original PR by Phil Price:_
>
> Fix a number of js/ts generation issues:
> - [js] Missing class name for generated services and processors; this makes
> instrumentation of outbound calls (e.g. which service are we calling in to)
> difficult. Generating a class name for es6 enables x.constructor.name to get
> generated name.
> - [js] Fix case where services have a method with an argument named
> "params", generated code generates an identifier in the "send_XXX" body named
> "params" which conflicts with the argument. Ensure the identifier in the body
> is uniquely named.
> - [js] Ensure that derived services (extends XYZService) correctly call
> super() in their constructor.
> - [ts] Ensure that derived services (extends XYZSerice) correctly specify
> the base class Client and Processor name
> - [js] Ensure that derived service clients do not redefine private fields
> (output, pClass, _seqId, _reqs) and call super();
> - [ts] Ensure derived service clients and processors do not redefine private
> fields in declaration.
> - [js] Missing class name for generated services and processors; this makes
> instrumentation of outbound calls (e.g. which service are we calling in to)
> difficult. Generating a class name for es6 enables x.constructor.name to get
> generated name.
> - [js] Fix case where services have a method with an argument named
> "params", generated code generates an identifier in the "send_XXX" body named
> "params" which conflicts with the argument. Ensure the identifier in the body
> is uniquely named.
> - [js] Ensure that derived services (extends XYZService) correctly call
> super() in their constructor.
> - [ts] Ensure that derived services (extends XYZSerice) correctly specify
> the base class Client and Processor name
> - [js] Ensure that derived service clients do not redefine private fields
> (output, pClass, _seqId, _reqs) and call super();
> - [ts] Ensure derived service clients and processors do not redefine private
> fields in declaration.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
