fishy opened a new pull request #2256: URL: https://github.com/apache/thrift/pull/2256
Client: go This is a follow up to 4db7a0af13ac9614e3e9758d42b2791040f4dc7e. Due to the go runtime bug [1], the 1ms ticker used by this feature could cause excessive cpu usage. So until the bug is fixed in go it's better to leave this behavior disabled by default. The instructions in the README file has been updated to how to enable this feature if needed. [1] https://github.com/golang/go/issues/27707 <!-- Explain the changes in the pull request below: --> <!-- We recommend you review the checklist/tips before submitting a pull request. --> - [x] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? (not required for trivial changes) - [x] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"? - [x] Did you squash your changes to a single commit? (not required, but preferred) - [x] Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"? - [ ] If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources. <!-- The Contributing Guide at: https://github.com/apache/thrift/blob/master/CONTRIBUTING.md has more details and tips for committing properly. --> ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
